Differential D19238

Add an async driver for document rendering and a crude "Hexdump" document engine
ClosedPublic
Actions

Authored by epriestley on Mar 19 2018, 5:59 PM.

Details

Reviewers: None
Maniphest Tasks: T13105: Plans: Rich presentation and diff rendering pipelines for various file types
Commits: rPf646153f4dbe: Add an async driver for document rendering and a crude "Hexdump" document engine

Summary

Depends on D19237. Ref T13105. This adds a (very basic) "Hexdump" engine (mostly just to have a second option to switch to) and a selector for choosing view modes.

Test Plan

Viewed some files, switched between audio/video/image/hexdump.

Diff Detail

Repository

rP Phabricator

Branch

doc2

Lint

Lint Warnings

Severity	Location	Code	Message
Warning	webroot/rsrc/js/application/files/behavior-document-engine.js:1	JAVELIN5	`javelinsymbols` Not In Path

Unit

Tests Passed

Build Status

Buildable 19881
Build 26944: Run Core Tests
Build 26943: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 19 2018, 5:59 PM

Harbormaster failed remote builds in B19881: Diff 46062!Mar 19 2018, 5:59 PM

epriestley requested review of this revision.Mar 19 2018, 7:40 PM

epriestley added a child revision: D19239: Add filesize limits for document rendering engines and support partial/complete rendering.

This revision was not accepted when it landed; it landed in state Needs Review.Mar 19 2018, 10:18 PM

Closed by commit rPf646153f4dbe: Add an async driver for document rendering and a crude "Hexdump" document engine (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T13108: Plans: 2018 Week 12 Bonus Content.Mar 20 2018, 2:46 PM

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

13 lines

src/

__phutil_library_map__.php

4 lines

applications/

files/

application/

PhabricatorFilesApplication.php

2 lines

controller/

PhabricatorFileDocumentController.php

113 lines

PhabricatorFileInfoController.php

66 lines

document/

PhabricatorAudioDocumentEngine.php

4 lines

PhabricatorDocumentEngine.php

48 lines

PhabricatorDocumentRef.php

8 lines

PhabricatorHexdumpDocumentEngine.php

83 lines

PhabricatorImageDocumentEngine.php

4 lines

PhabricatorVideoDocumentEngine.php

4 lines

PhabricatorVoidDocumentEngine.php

4 lines

webroot/

rsrc/

css/

phui/

phui-property-list-view.css

11 lines

js/

application/

files/

behavior-document-engine.js

67 lines

Diff 46062

View Options

resources/celerity/map.php

View Options

src/__phutil_library_map__.php

View Options

src/applications/files/application/PhabricatorFilesApplication.php

View Options

src/applications/files/controller/PhabricatorFileDocumentController.php

View Options

src/applications/files/controller/PhabricatorFileInfoController.php

View Options

src/applications/files/document/PhabricatorAudioDocumentEngine.php

View Options

src/applications/files/document/PhabricatorDocumentEngine.php

View Options

src/applications/files/document/PhabricatorDocumentRef.php

View Options

src/applications/files/document/PhabricatorHexdumpDocumentEngine.php

View Options

src/applications/files/document/PhabricatorImageDocumentEngine.php

View Options

src/applications/files/document/PhabricatorVideoDocumentEngine.php

View Options

src/applications/files/document/PhabricatorVoidDocumentEngine.php

View Options

webroot/rsrc/css/phui/phui-property-list-view.css

View Options

webroot/rsrc/js/application/files/behavior-document-engine.js

Add an async driver for document rendering and a crude "Hexdump" document engineClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 46062

resources/celerity/map.php

src/__phutil_library_map__.php

src/applications/files/application/PhabricatorFilesApplication.php

src/applications/files/controller/PhabricatorFileDocumentController.php

src/applications/files/controller/PhabricatorFileInfoController.php

src/applications/files/document/PhabricatorAudioDocumentEngine.php

src/applications/files/document/PhabricatorDocumentEngine.php

src/applications/files/document/PhabricatorDocumentRef.php

src/applications/files/document/PhabricatorHexdumpDocumentEngine.php

src/applications/files/document/PhabricatorImageDocumentEngine.php

src/applications/files/document/PhabricatorVideoDocumentEngine.php

src/applications/files/document/PhabricatorVoidDocumentEngine.php

webroot/rsrc/css/phui/phui-property-list-view.css

webroot/rsrc/js/application/files/behavior-document-engine.js

Add an async driver for document rendering and a crude "Hexdump" document engine
ClosedPublic
Actions

Revision Contents
Changeset List