Differential D19211

Allow custom actions in Differential to explicitly override "accept" stickiness
ClosedPublic
Actions

Authored by epriestley on Mar 12 2018, 11:54 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Jan 9, 9:17 PM

	Unknown Object (File)
	Thu, Jan 9, 8:38 PM

	Unknown Object (File)
	Thu, Jan 9, 8:37 PM

	Unknown Object (File)
	Thu, Jan 9, 8:35 PM

	Unknown Object (File)
	Wed, Jan 1, 2:09 PM

	Unknown Object (File)
	Sat, Dec 28, 6:45 PM

	Unknown Object (File)
	Fri, Dec 20, 7:50 PM

	Unknown Object (File)
	Mon, Dec 16, 12:29 PM

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13102: Plans: 2018 Week 11 Bonus Content
Commits: rP1e93b49b1bf2: Allow custom actions in Differential to explicitly override "accept" stickiness

Summary

See PHI431. Ref T13102. An install is interested in a custom "non-sticky" accept action, roughly.

On the one hand, this is a pretty hacky patch. However, I suspect it inches us closer to T731, and I'm generally comfortable with exploring the realms of "Accept Next Update", "Unblock Without Accepting", etc., as long as most of it doesn't end up enabled by default in the upstream.

Test Plan

Accepted and updated revisions normally, saw accepts respect global stickiness.
Modified the "Accept" action to explicitly be unsticky, saw nonsticky accept behavior after update.

Diff Detail

Repository

Branch

sticky1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 19822
Build 26857: Run Core Tests
Build 26856: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 12 2018, 11:54 PM

Harbormaster completed remote builds in B19821: Diff 46003.Mar 12 2018, 11:55 PM

epriestley requested review of this revision.Mar 12 2018, 11:55 PM

Remove some unused variables.

Harbormaster completed remote builds in B19822: Diff 46004.Mar 12 2018, 11:58 PM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 13 2018, 12:10 AM

Closed by commit rP1e93b49b1bf2: Allow custom actions in Differential to explicitly override "accept" stickiness (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

sql/

autopatches/

20180312.reviewers.01.options.sql

2 lines

20180312.reviewers.02.optionsdefault.sql

2 lines

src/

applications/

differential/

editor/

DifferentialTransactionEditor.php

52 lines

storage/

DifferentialReviewer.php

13 lines

xaction/

DifferentialRevisionReviewTransaction.php

11 lines

DifferentialRevisionVoidTransaction.php

46 lines

Diff 46004

resources/sql/autopatches/20180312.reviewers.01.options.sql

Loading...

resources/sql/autopatches/20180312.reviewers.02.optionsdefault.sql

Loading...

src/applications/differential/editor/DifferentialTransactionEditor.php

Loading...

src/applications/differential/storage/DifferentialReviewer.php

Loading...

src/applications/differential/xaction/DifferentialRevisionReviewTransaction.php

Loading...

src/applications/differential/xaction/DifferentialRevisionVoidTransaction.php

Loading...