Page MenuHomePhabricator

Allow custom actions in Differential to explicitly override "accept" stickiness
ClosedPublic

Authored by epriestley on Mar 12 2018, 11:54 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, May 2, 3:18 AM
Unknown Object (File)
Thu, Apr 25, 12:10 AM
Unknown Object (File)
Thu, Apr 11, 8:27 AM
Unknown Object (File)
Fri, Apr 5, 9:37 PM
Unknown Object (File)
Mar 31 2024, 2:28 AM
Unknown Object (File)
Mar 31 2024, 2:28 AM
Unknown Object (File)
Mar 31 2024, 2:28 AM
Unknown Object (File)
Mar 31 2024, 2:27 AM
Subscribers
None

Details

Summary

See PHI431. Ref T13102. An install is interested in a custom "non-sticky" accept action, roughly.

On the one hand, this is a pretty hacky patch. However, I suspect it inches us closer to T731, and I'm generally comfortable with exploring the realms of "Accept Next Update", "Unblock Without Accepting", etc., as long as most of it doesn't end up enabled by default in the upstream.

Test Plan
  • Accepted and updated revisions normally, saw accepts respect global stickiness.
  • Modified the "Accept" action to explicitly be unsticky, saw nonsticky accept behavior after update.

Diff Detail

Repository
rP Phabricator
Branch
sticky1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19822
Build 26857: Run Core Tests
Build 26856: arc lint + arc unit

Event Timeline

  • Remove some unused variables.
This revision was not accepted when it landed; it landed in state Needs Review.Mar 13 2018, 12:10 AM
This revision was automatically updated to reflect the committed changes.