Diffusion Phabricator 3c4f31e4b921

Dynamically composite favicons from customizable sources
3c4f31e4b921
Actions

Tags

None

Referenced Files

None

Subscribers

None

Description

Dynamically composite favicons from customizable sources

Summary: Ref T13103. Make favicons customizable, and perform dynamic compositing to add marker to indicate things like "unread messages".

Test Plan: Viewed favicons in Safari, Firefox and Chrome. With unread messages, saw pink dot composited into icon.

Maniphest Tasks: T13103

Differential Revision: https://secure.phabricator.com/D19209

Details

Provenance

epriestley	Authored on Mar 12 2018, 10:07 PM
epriestley	Pushed on Mar 12 2018, 10:28 PM

Differential Revision

D19209: Dynamically composite favicons from customizable sources

Parents

rP9d0cf3c8b82d: Before anyone notices, break the API

Branches

Unknown

Tags

Unknown

Tasks

T13103: Document favicon customization and validate the "ui.favicons" configuration option

Build Status

Buildable 19819
Build 26851: Run Core Tests

Event Timeline

epriestley committed rP3c4f31e4b921: Dynamically composite favicons from customizable sources (authored by epriestley).Mar 12 2018, 10:28 PM

epriestley added a task: T13103: Document favicon customization and validate the "ui.favicons" configuration option.

Harbormaster completed building B19819: rP3c4f31e4b921: Dynamically composite favicons from customizable sources.Mar 12 2018, 10:30 PM

• abdul raised a concern with this commit.Mar 13 2018, 1:41 PM

• abdul added a subscriber: • abdul.

• abdul added inline comments.

/src/applications/files/favicon/PhabricatorFaviconRef.php
404	I think, this line has broken my installation. I updated phabricator (and libphutil/arcanist) today. This is first time in last seven years that Phabricator update broke the installation. Some details: EXCEPTION: (Error) Call to undefined method PhutilSortVector::getSelf() at [<phutil>/src/utils/utils.php:147] PHP message: arcanist(head=master, ref.master=dcd7ef66d0e4), phabricator(head=master, ref.master=207f67d03d7a, custom=2), phutil(head=master, ref.master=dedf260c7755) PHP message: #0 mpull(array, string) called at [<phutil>/src/utils/utils.php:419] PHP message: #1 msortv(array, string) called at [<phabricator>/src/applications/files/favicon/PhabricatorFaviconRef.php:404]

This commit now has outstanding concerns.Mar 13 2018, 1:41 PM

epriestley removed an auditor: • abdul.Mar 13 2018, 4:29 PM

epriestley removed a subscriber: • abdul.

This commit no longer requires audit.Mar 13 2018, 4:29 PM

Changes (39)

Path

Size

resources/

builtin/

favicon/

dot-pink-64x64.png

dot-red-64x64.png

celerity/

	resources/	builtin/	favicon/
	webroot/	rsrc/	favicons/

	default-120x120.png
	apple-touch-icon-120x120.png

	default-128x128.png
	favicon-128.png

	default-152x152.png
	apple-touch-icon-152x152.png

	default-76x76.png
	apple-touch-icon-76x76.png

src/

__phutil_library_map__.php

applications/

config/

option/

PhabricatorUIConfigOptions.php

files/

PhabricatorFaviconRef.php

PhabricatorFaviconRefQuery.php

storage/

PhabricatorFile.php

system/

application/

PhabricatorSystemApplication.php

controller/

PhabricatorSystemFaviconController.php

view/

page/

PhabricatorBarePageView.php

menu/

PhabricatorMainMenuView.php

webroot/

rsrc/

favicons/

apple-touch-icon-114x114.png

apple-touch-icon-120x120.png

apple-touch-icon-144x144.png

apple-touch-icon-152x152.png

apple-touch-icon-57x57.png

apple-touch-icon-60x60.png

apple-touch-icon-72x72.png

apple-touch-icon-76x76.png

favicon-128.png

favicon-196x196.png

favicon-32x32.png

favicon-96x96.png

favicon-mention.ico

favicon-message.ico

mstile-144x144.png

mstile-150x150.png

mstile-310x150.png

mstile-310x310.png

mstile-70x70.png

rP3c4f31e4b921

resources/builtin/favicon/default-120x120.png

Loading...

resources/builtin/favicon/default-128x128.png

Loading...

resources/builtin/favicon/default-152x152.png

Loading...

resources/builtin/favicon/default-76x76.png

Loading...

resources/builtin/favicon/dot-pink-64x64.png

Loading...

resources/builtin/favicon/dot-red-64x64.png

Loading...

resources/celerity/map.php

Loading...

src/__phutil_library_map__.php

Loading...

src/applications/config/option/PhabricatorUIConfigOptions.php

Loading...

src/applications/files/favicon/PhabricatorFaviconRef.php

Loading...

src/applications/files/favicon/PhabricatorFaviconRefQuery.php

Loading...

src/applications/files/storage/PhabricatorFile.php

Loading...

src/applications/system/application/PhabricatorSystemApplication.php

Loading...

src/applications/system/controller/PhabricatorSystemFaviconController.php

Loading...

src/view/page/PhabricatorBarePageView.php

Loading...

src/view/page/menu/PhabricatorMainMenuView.php

Loading...

webroot/favicon.ico

Loading...

webroot/rsrc/favicons/apple-touch-icon-114x114.png

Loading...

webroot/rsrc/favicons/apple-touch-icon-120x120.png

Loading...

webroot/rsrc/favicons/apple-touch-icon-144x144.png

Loading...

webroot/rsrc/favicons/apple-touch-icon-152x152.png

Loading...

webroot/rsrc/favicons/apple-touch-icon-57x57.png

Loading...

webroot/rsrc/favicons/apple-touch-icon-60x60.png

Loading...

webroot/rsrc/favicons/apple-touch-icon-72x72.png

Loading...

webroot/rsrc/favicons/apple-touch-icon-76x76.png

Loading...

webroot/rsrc/favicons/favicon-128.png

Loading...

webroot/rsrc/favicons/favicon-196x196.png

Loading...

webroot/rsrc/favicons/favicon-32x32.png

Loading...

webroot/rsrc/favicons/favicon-96x96.png

Loading...

webroot/rsrc/favicons/favicon-mention.ico

Loading...

webroot/rsrc/favicons/favicon-message.ico

Loading...

webroot/rsrc/favicons/favicon.ico

Loading...

webroot/rsrc/favicons/mstile-144x144.png

Loading...

webroot/rsrc/favicons/mstile-150x150.png

Loading...

webroot/rsrc/favicons/mstile-310x150.png

Loading...

webroot/rsrc/favicons/mstile-310x310.png

Loading...

webroot/rsrc/favicons/mstile-70x70.png

Loading...