Differential D19203

Possibly fix memes in email
ClosedPublic
Actions

Authored by epriestley on Mar 8 2018, 7:04 PM.

Tags

None

Referenced Files

	F15475055: D19203.id45989.diff
	Sun, Apr 6, 3:09 PM

	F15475054: D19203.id45985.diff
	Sun, Apr 6, 3:09 PM

	F15475053: D19203.id.diff
	Sun, Apr 6, 3:09 PM

	F15470299: D19203.diff
	Fri, Apr 4, 9:32 PM

	F15449956: D19203.id45989.diff
	Fri, Mar 28, 1:08 PM

	F15449672: D19203.id45985.diff
	Fri, Mar 28, 11:36 AM

	F15441828: D19203.id.diff
	Wed, Mar 26, 8:13 PM

	F15436487: D19203.diff
	Tue, Mar 25, 2:33 PM

View All Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13101: The "{img ...}" and "{meme ...}" remarkup rules violate the new Content-Security-Policy
Commits: rP10b3ddf42657: Possibly fix memes in email

Summary

Depends on D19201. Ref T13101. This likely produces relatively stable-ish image references for email.

They currently TTL after 30 days but this makes the jokes more exclusive and special so it's a feature, not a bug.

Test Plan

I'm just going to test this in production because I'm a ninja superstar developer.

Diff Detail

Repository

rP Phabricator

Branch

meme5

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 19801
Build 26828: Run Core Tests
Build 26827: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 8 2018, 7:04 PM

Harbormaster completed remote builds in B19801: Diff 45985.Mar 8 2018, 7:05 PM

epriestley requested review of this revision.Mar 8 2018, 7:05 PM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 8 2018, 7:09 PM

Closed by commit rP10b3ddf42657: Possibly fix memes in email (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

macro/

engine/

PhabricatorMemeEngine.php

5 lines

markup/

PhabricatorMemeRemarkupRule.php

81 lines

Diff 45985

View Options

src/applications/macro/engine/PhabricatorMemeEngine.php