Page MenuHomePhabricator
Differential D19185

Use "pathIndex" in some owners package queries to improve query plans
ClosedPublic
Actions

Authored by epriestley on Mar 7 2018, 4:28 AM.
Tags
None
Referenced Files
F13217695: D19185.diff
Sat, May 18, 7:19 AM
F13216137: D19185.id45952.diff
Fri, May 17, 10:33 PM
F13211985: D19185.diff
Fri, May 17, 6:17 AM
F13195928: D19185.diff
Sun, May 12, 10:45 PM
F13195621: D19185.diff
Sun, May 12, 10:31 PM
F13190160: D19185.id.diff
Sat, May 11, 7:57 AM
F13189508: D19185.id45947.diff
Sat, May 11, 6:07 AM
F13179630: D19185.diff
Wed, May 8, 9:19 PM
View All 75 Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T11015: Owners has perplexing behavior when directory paths are not terminated with a slash
Commits
rP516aaad3410c: Use "pathIndex" in some owners package queries to improve query plans
Summary

Depends on D19184. Ref T11015. Now that we have a digest index column, we can improve some of the queries a bit.

Test Plan
  • Ran queries from revision pages before and after with and without EXPLAIN.
  • Saw the same results with much better EXPLAIN plans.
  • Fragment size is now fixed at 12 bytes per fragment, so we can shove more of them in a single query.

Diff Detail

Repository
rP Phabricator
Branch
opath5
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19760
Build 26768: Run Core Tests
Build 26767: arc lint + arc unit

Revision Contents
Changeset List

PathSize
src/
applications/
owners/
query/
20 lines
storage/
11 lines
3 lines

Diff 45947

View Options

src/applications/owners/query/PhabricatorOwnersPackageQuery.php

Loading...
View Options

src/applications/owners/storage/PhabricatorOwnersPackage.php

Loading...
View Options

src/applications/owners/storage/PhabricatorOwnersPath.php

Loading...
Phabricator · Built by Phacility