Paths

Table of Contentst

Differential D19183

Allow owners paths to be arbitrarily long and add storage for display paths
ClosedPublic
Actions

Authored by epriestley on Mar 7 2018, 3:54 AM.

Tags

None

Referenced Files

	F17731741: D19183.id45950.diff
	Sun, Jul 20, 2:38 AM

	F17729740: D19183.diff
	Sat, Jul 19, 7:56 PM

	Unknown Object (File)
	May 2 2025, 2:56 PM

	Unknown Object (File)
	May 1 2025, 9:13 AM

	Unknown Object (File)
	Apr 25 2025, 6:19 AM

	Unknown Object (File)
	Apr 11 2025, 1:15 PM

	Unknown Object (File)
	Apr 8 2025, 8:29 AM

	Unknown Object (File)
	Apr 8 2025, 3:41 AM

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T11015: Owners has perplexing behavior when directory paths are not terminated with a slash
Commits: rPadde4089b49b: Allow owners paths to be arbitrarily long and add storage for display paths

Summary

Depends on D19182. Ref T11015. This changes path from text255 to longtext because paths may be arbitrarily long.

It adds pathDisplay to prepare for display paths and storage paths having different values. For now, pathDisplay is copied from path and always has the same value.

Test Plan

Ran migration, checked database for sanity (all pathDisplay and path values identical).
Added new paths, saw pathDisplay and path get the same values.
Added an unreasonably enormous path with far more than 255 characters.

Diff Detail

Repository

Branch

opath3

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 19758
Build 26764: Run Core Tests
Build 26763: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 7 2018, 3:54 AM

Harbormaster completed remote builds in B19758: Diff 45945.Mar 7 2018, 3:55 AM

epriestley requested review of this revision.Mar 7 2018, 3:55 AM

epriestley added a child revision: D19184: Treat Owners paths like "/src/backend" and "/src/backend/" identically.Mar 7 2018, 4:14 AM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 7 2018, 4:31 AM

Closed by commit rPadde4089b49b: Allow owners paths to be arbitrarily long and add storage for display paths (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

sql/

autopatches/

20180306.opath.05.longpath.sql

2 lines

20180306.opath.06.pathdisplay.sql

2 lines

20180306.opath.07.copypaths.sql

2 lines

src/

applications/

owners/

storage/

PhabricatorOwnersPath.php

5 lines

Diff 45945

resources/sql/autopatches/20180306.opath.05.longpath.sql

Loading...

resources/sql/autopatches/20180306.opath.06.pathdisplay.sql

Loading...

resources/sql/autopatches/20180306.opath.07.copypaths.sql

Loading...

src/applications/owners/storage/PhabricatorOwnersPath.php

Loading...