Provide a more tailored error message when a Herald rule fails because of PCRE limits
ClosedPublic
Actions

Authored by epriestley on Mar 6 2018, 8:16 PM.

Details

Reviewers: None
Maniphest Tasks: T13100: PCRE segfaults readily with default "pcre.backtrack_limit" and "pcre.recursion_limit" values
Commits: rPb52783af80bd: (stable) Provide a more tailored error message when a Herald rule fails because…
rP573bf15124bb: Provide a more tailored error message when a Herald rule fails because of PCRE…

Summary

Ref T13100. Since rules may begin failing for PRCE configuration reasons soon, provide a more complete explanation of possible causes in the UI.

Test Plan

Faked this, hit it via test console, saw explanation in web UI.

Repository

rP Phabricator

Branch

preg1

Lint

Lint Passed

Unit

Tests Passed

Build Status

This revision was not accepted when it landed; it landed in state Needs Review.Mar 6 2018, 8:17 PM

epriestley requested review of this revision.

This revision was automatically updated to reflect the committed changes.

Path

Size

src/

applications/

herald/

adapter/

8 lines