Differential D19178

Provide a more tailored error message when a Herald rule fails because of PCRE limits
ClosedPublic
Actions

Authored by epriestley on Mar 6 2018, 8:16 PM.

Tags

None

Referenced Files

	F15458393: D19178.id45938.diff
	Sun, Mar 30, 11:35 PM

	F15455600: D19178.id45936.diff
	Sun, Mar 30, 3:29 AM

	F15455000: D19178.id.diff
	Sat, Mar 29, 9:48 PM

	F15448529: D19178.diff
	Fri, Mar 28, 5:27 AM

	F15444755: D19178.id.diff
	Thu, Mar 27, 11:06 AM

	F15436626: D19178.id45938.diff
	Tue, Mar 25, 3:30 PM

	F15436261: D19178.id45936.diff
	Tue, Mar 25, 12:59 PM

	Unknown Object (File)
	Feb 25 2025, 12:36 PM

View All Files

Subscribers

None

Details

Reviewers: None
Maniphest Tasks: T13100: PCRE segfaults readily with default "pcre.backtrack_limit" and "pcre.recursion_limit" values
Commits: rPb52783af80bd: (stable) Provide a more tailored error message when a Herald rule fails because…
rP573bf15124bb: Provide a more tailored error message when a Herald rule fails because of PCRE…

Summary

Ref T13100. Since rules may begin failing for PRCE configuration reasons soon, provide a more complete explanation of possible causes in the UI.

Test Plan

Faked this, hit it via test console, saw explanation in web UI.

Diff Detail

Repository

rP Phabricator

Branch

preg1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 19747
Build 26748: Run Core Tests
Build 26747: arc lint + arc unit

Event Timeline

epriestley created this revision.Mar 6 2018, 8:16 PM

Harbormaster completed remote builds in B19747: Diff 45936.Mar 6 2018, 8:17 PM

This revision was not accepted when it landed; it landed in state Needs Review.Mar 6 2018, 8:17 PM

epriestley requested review of this revision.

Closed by commit rP573bf15124bb: Provide a more tailored error message when a Herald rule fails because of PCRE… (authored by epriestley). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

herald/

adapter/

HeraldAdapter.php

8 lines

Diff 45936

View Options

src/applications/herald/adapter/HeraldAdapter.php

Provide a more tailored error message when a Herald rule fails because of PCRE limitsClosedPublicActions