Provide a more tailored error message when a Herald rule fails because of PCRE…
573bf15124bb
Actions

Description

Provide a more tailored error message when a Herald rule fails because of PCRE limits

Summary: Ref T13100. Since rules may begin failing for PRCE configuration reasons soon, provide a more complete explanation of possible causes in the UI.

Test Plan: Faked this, hit it via test console, saw explanation in web UI.

Maniphest Tasks: T13100

Differential Revision: https://secure.phabricator.com/D19178

Details

Provenance

epriestley	Authored on Mar 6 2018, 8:12 PM
epriestley	Pushed on Mar 6 2018, 8:19 PM

Differential Revision

D19178: Provide a more tailored error message when a Herald rule fails because of PCRE limits

Parents

rPdbccfb234f8d: Perform a client-side redirect after OAuth server authorization

Branches

Unknown

Tags

Unknown

Tasks

T13100: PCRE segfaults readily with default "pcre.backtrack_limit" and "pcre.recursion_limit" values

Build Status

Buildable 19749
Build 26750: Run Core Tests

Event Timeline

epriestley committed rP573bf15124bb: Provide a more tailored error message when a Herald rule fails because of PCRE… (authored by epriestley).Mar 6 2018, 8:18 PM

epriestley added a task: T13100: PCRE segfaults readily with default "pcre.backtrack_limit" and "pcre.recursion_limit" values.

Harbormaster completed building B19749: rP573bf15124bb: Provide a more tailored error message when a Herald rule fails because of PCRE….Mar 6 2018, 8:21 PM

Changes (1)

Path

Size

src/

applications/

herald/

adapter/

HeraldAdapter.php

rP573bf15124bb

View Options

src/applications/herald/adapter/HeraldAdapter.php