Page MenuHomePhabricator
Differential D19178

Provide a more tailored error message when a Herald rule fails because of PCRE limits
ClosedPublic
Actions

Authored by epriestley on Mar 6 2018, 8:16 PM.
Tags
None
Referenced Files
F13304178: D19178.diff
Sat, Jun 8, 8:41 AM
F13286883: D19178.diff
Tue, Jun 4, 7:49 AM
F13273825: D19178.diff
Fri, May 31, 2:45 AM
F13267071: D19178.diff
Wed, May 29, 12:46 AM
F13234451: D19178.diff
Tue, May 21, 3:25 AM
F13213934: D19178.diff
Fri, May 17, 8:15 AM
Unknown Object (File)
May 7 2024, 9:27 AM
Unknown Object (File)
May 3 2024, 9:14 AM
View All 97 Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13100: PCRE segfaults readily with default "pcre.backtrack_limit" and "pcre.recursion_limit" values
Commits
rPb52783af80bd: (stable) Provide a more tailored error message when a Herald rule fails because…
rP573bf15124bb: Provide a more tailored error message when a Herald rule fails because of PCRE…
Summary

Ref T13100. Since rules may begin failing for PRCE configuration reasons soon, provide a more complete explanation of possible causes in the UI.

Test Plan

Faked this, hit it via test console, saw explanation in web UI.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley created this revision.Mar 6 2018, 8:16 PM
Harbormaster completed remote builds in B19747: Diff 45936.Mar 6 2018, 8:17 PM
This revision was not accepted when it landed; it landed in state Needs Review.Mar 6 2018, 8:17 PM
epriestley requested review of this revision.
Closed by commit rP573bf15124bb: Provide a more tailored error message when a Herald rule fails because of PCRE… (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
herald/
adapter/
8 lines

Diff 45938

View Options

src/applications/herald/adapter/HeraldAdapter.php

Loading...
Phabricator · Built by Phacility