Page MenuHomePhabricator

Provide default values for table view properties which are `count`ed
ClosedPublic

Authored by yelirekim on Feb 25 2018, 8:19 PM.
Tags
None
Referenced Files
F14111108: D19140.diff
Wed, Nov 27, 8:18 PM
Unknown Object (File)
Thu, Nov 21, 7:40 PM
Unknown Object (File)
Wed, Nov 20, 11:36 AM
Unknown Object (File)
Fri, Nov 15, 9:52 PM
Unknown Object (File)
Tue, Nov 12, 10:01 AM
Unknown Object (File)
Mon, Nov 11, 6:00 AM
Unknown Object (File)
Thu, Nov 7, 11:47 PM
Unknown Object (File)
Oct 17 2024, 10:24 PM
Subscribers

Details

Summary

PHP 7.2 has changed the behavior of count, you must provide an array or Countable as a parameter, otherwise a warning is generated. These two class members are counted during rendering, and are commonly left as null properties.

https://wiki.php.net/rfc/counting_non_countables

Test Plan

Browsed around my install and stopped seeing count(): Parameter must be an array or an object that implements Countable at [AphrontTableView.php:153] everywhere.

Diff Detail

Repository
rP Phabricator
Branch
tableview_null_countables (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19657
Build 26620: Run Core Tests
Build 26619: arc lint + arc unit

Event Timeline

yelirekim edited the test plan for this revision. (Show Details)
This revision is now accepted and ready to land.Feb 25 2018, 8:31 PM

(See D18964 previously -- I'm still on 7.1 locally so there may be a few more of these lurking around.)

This revision was automatically updated to reflect the committed changes.