Page MenuHomePhabricator

Provide default values for table view properties which are `count`ed
ClosedPublic

Authored by yelirekim on Feb 25 2018, 8:19 PM.
Tags
None
Referenced Files
F15336979: D19140.id45847.diff
Sun, Mar 9, 3:37 AM
F15336978: D19140.id45846.diff
Sun, Mar 9, 3:37 AM
F15336977: D19140.id.diff
Sun, Mar 9, 3:37 AM
F15336976: D19140.diff
Sun, Mar 9, 3:37 AM
Unknown Object (File)
Wed, Feb 26, 12:30 PM
Unknown Object (File)
Feb 16 2025, 5:53 PM
Unknown Object (File)
Feb 11 2025, 11:25 PM
Unknown Object (File)
Feb 9 2025, 9:22 AM
Subscribers

Details

Summary

PHP 7.2 has changed the behavior of count, you must provide an array or Countable as a parameter, otherwise a warning is generated. These two class members are counted during rendering, and are commonly left as null properties.

https://wiki.php.net/rfc/counting_non_countables

Test Plan

Browsed around my install and stopped seeing count(): Parameter must be an array or an object that implements Countable at [AphrontTableView.php:153] everywhere.

Diff Detail

Repository
rP Phabricator
Branch
tableview_null_countables (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19657
Build 26620: Run Core Tests
Build 26619: arc lint + arc unit

Event Timeline

yelirekim edited the test plan for this revision. (Show Details)
This revision is now accepted and ready to land.Feb 25 2018, 8:31 PM

(See D18964 previously -- I'm still on 7.1 locally so there may be a few more of these lurking around.)

This revision was automatically updated to reflect the committed changes.