PHP 7.2 has changed the behavior of count, you must provide an array or Countable as a parameter, otherwise a warning is generated. These two class members are counted during rendering, and are commonly left as null properties.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Commits
- rP7aab7e80af28: Provide default values for table view properties which are `count`ed
Browsed around my install and stopped seeing count(): Parameter must be an array or an object that implements Countable at [AphrontTableView.php:153] everywhere.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- tableview_null_countables (branched from master)
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 19657 Build 26620: Run Core Tests Build 26619: arc lint + arc unit
Event Timeline
Comment Actions
(See D18964 previously -- I'm still on 7.1 locally so there may be a few more of these lurking around.)