Paths

Table of Contentst

Differential D19140

Provide default values for table view properties which are `count`ed
ClosedPublic
Actions

Authored by yelirekim on Feb 25 2018, 8:19 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Apr 29, 3:37 PM

	Unknown Object (File)
	Sun, Apr 28, 10:00 PM

	Unknown Object (File)
	Sun, Apr 28, 7:06 AM

	Unknown Object (File)
	Wed, Apr 24, 11:37 PM

	Unknown Object (File)
	Sun, Apr 21, 6:15 PM

	Unknown Object (File)
	Fri, Apr 19, 7:27 PM

	Unknown Object (File)
	Thu, Apr 11, 7:57 AM

	Unknown Object (File)
	Apr 1 2024, 6:06 AM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Commits

rP7aab7e80af28: Provide default values for table view properties which are `count`ed

Summary

PHP 7.2 has changed the behavior of count, you must provide an array or Countable as a parameter, otherwise a warning is generated. These two class members are counted during rendering, and are commonly left as null properties.

https://wiki.php.net/rfc/counting_non_countables

Test Plan

Browsed around my install and stopped seeing count(): Parameter must be an array or an object that implements Countable at [AphrontTableView.php:153] everywhere.

Diff Detail

Repository

Branch

tableview_null_countables (branched from master)

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 19657
Build 26620: Run Core Tests
Build 26619: arc lint + arc unit

Event Timeline

yelirekim created this revision.Feb 25 2018, 8:19 PM

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptFeb 25 2018, 8:19 PM

Herald added a subscriber: epriestley. · View Herald Transcript

Harbormaster completed remote builds in B19657: Diff 45846.Feb 25 2018, 8:20 PM

yelirekim requested review of this revision.Feb 25 2018, 8:20 PM

yelirekim edited the summary of this revision. (Show Details)Feb 25 2018, 8:20 PM

yelirekim edited the test plan for this revision. (Show Details)

epriestley accepted this revision.Feb 25 2018, 8:31 PM

This revision is now accepted and ready to land.Feb 25 2018, 8:31 PM

Herald added a subscriber: Korvin. · View Herald TranscriptFeb 25 2018, 8:31 PM

(See D18964 previously -- I'm still on 7.1 locally so there may be a few more of these lurking around.)

Closed by commit rP7aab7e80af28: Provide default values for table view properties which are `count`ed (authored by yelirekim). · Explain WhyFeb 25 2018, 9:54 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

view/

control/

AphrontTableView.php

4 lines

Diff 45846

src/view/control/AphrontTableView.php

Loading...