Page MenuHomePhabricator
Differential D19095

Mostly use PhrictionContentQuery to load PhrictionContent objects
ClosedPublic
Actions

Authored by epriestley on Feb 15 2018, 1:33 PM.
Tags
None
Referenced Files
F19511969: D19095.diff
Mon, Jan 12, 10:07 AM
F18897898: D19095.id.diff
Nov 7 2025, 5:48 PM
F18877521: D19095.diff
Nov 6 2025, 9:44 AM
F18836807: D19095.id45775.diff
Oct 27 2025, 3:41 AM
F18836805: D19095.id45761.diff
Oct 27 2025, 3:41 AM
F18836801: D19095.id.diff
Oct 27 2025, 3:41 AM
F18833934: D19095.diff
Oct 26 2025, 6:44 AM
F18786132: D19095.id.diff
Oct 14 2025, 5:27 PM
View All Files
Subscribers
None

Details

Reviewers
None
Maniphest Tasks
T13077: Plans: Phriction modern "v3" APIs, Drafts
Commits
rPf742d00c2894: Mostly use PhrictionContentQuery to load PhrictionContent objects
Summary

Depends on D19094. Ref T13077. Use modern infrastructure to perform these loads. I left a couple of calls in the older API methods unconverted.

Test Plan

Viewed documents. Viewed older versions. Viewed diffs. Did revert edits to older versions.

Diff Detail

Repository
rP Phabricator
Branch
phriction4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19565
Build 26481: Run Core Tests
Build 26480: arc lint + arc unit

Event Timeline

epriestley created this revision.Feb 15 2018, 1:33 PM
Harbormaster completed remote builds in B19565: Diff 45761.Feb 15 2018, 1:35 PM
epriestley requested review of this revision.Feb 15 2018, 1:35 PM
epriestley added a child revision: D19096: Make PhrictionContent "description" non-nullable.Feb 15 2018, 1:50 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 16 2018, 1:44 AM
Closed by commit rPf742d00c2894: Mostly use PhrictionContentQuery to load PhrictionContent objects (authored by epriestley). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 45761

View Options

src/applications/phriction/controller/PhrictionDiffController.php

Loading...
View Options

src/applications/phriction/controller/PhrictionDocumentController.php

Loading...
View Options

src/applications/phriction/controller/PhrictionEditController.php

Loading...
View Options

src/applications/phriction/query/PhrictionContentQuery.php

Loading...
View Options

src/applications/phriction/query/PhrictionDocumentQuery.php

Loading...
View Options

src/applications/phriction/storage/PhrictionDocument.php

Loading...
Phabricator · Built by Phacility