Page MenuHomePhabricator

When `bin/drydock lease` is interrupted, release leases
ClosedPublic

Authored by epriestley on Feb 13 2018, 12:24 PM.
Tags
None
Referenced Files
F13182890: D19073.id45717.diff
Fri, May 10, 4:48 AM
F13182066: D19073.id.diff
Thu, May 9, 7:17 PM
Unknown Object (File)
Fri, May 3, 4:00 AM
Unknown Object (File)
Mon, Apr 29, 4:14 PM
Unknown Object (File)
Sun, Apr 28, 1:06 PM
Unknown Object (File)
Wed, Apr 24, 11:58 PM
Unknown Object (File)
Fri, Apr 19, 2:49 AM
Unknown Object (File)
Apr 11 2024, 8:14 AM
Subscribers
Restricted Owners Package

Details

Summary

Depends on D19072. Ref T13073. Currently, you can leave leases stranded by using ^C to interrupt the script. Handle signals and release leases on destruction if they haven't activated yet.

Also, print out more useful information before and after activation.

Test Plan

Mashed ^C while runnning bin/drydock lease ... --trace, saw the lease release.

Diff Detail

Repository
rP Phabricator
Branch
dry4
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/drydock/management/DrydockManagementLeaseWorkflow.php:92XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 19520
Build 26414: Run Core Tests
Build 26413: arc lint + arc unit