Page MenuHomePhabricator

Add some sytem locale utilities to libphutil
ClosedPublic

Authored by epriestley on Feb 4 2018, 3:52 PM.
Tags
None
Referenced Files
F15478311: D18990.id45555.diff
Mon, Apr 7, 9:54 PM
F15476592: D18990.id45545.diff
Mon, Apr 7, 7:38 AM
F15432413: D18990.id45555.diff
Mon, Mar 24, 6:02 PM
F15427246: D18990.id45545.diff
Sun, Mar 23, 1:26 PM
F15422187: D18990.id45542.diff
Sat, Mar 22, 6:26 AM
F15422060: D18990.id45555.diff
Sat, Mar 22, 5:08 AM
F15420992: D18990.id45545.diff
Fri, Mar 21, 7:56 PM
F15417976: D18990.id.diff
Thu, Mar 20, 7:49 PM
Subscribers
None

Details

Summary

Ref T13060. Ref T7339. Ref T5554. Although I don't plan to pursue resolving the latter two issues for now, I think we do have enough information to be confident that setlocale() is the ultimate pathway forward.

Add some wrappers with error checks and unit tests for the day that we eventually tackle T7339/T5554, and so we're on better footing if the setlocale() change in T13060 has unintended effects.

Test Plan

Ran unit tests, got a pass.

Diff Detail

Repository
rPHU libphutil
Branch
utf83
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19335
Build 26135: Run Core Tests
Build 26134: arc lint + arc unit

Event Timeline

  • Add a test that phutil_set_system_locale('duck.quack') raises an exception.
This revision is now accepted and ready to land.Feb 5 2018, 8:27 PM
This revision was automatically updated to reflect the committed changes.