Page MenuHomePhabricator

Add some sytem locale utilities to libphutil
ClosedPublic

Authored by epriestley on Feb 4 2018, 3:52 PM.
Tags
None
Referenced Files
F13146763: D18990.diff
Fri, May 3, 10:22 AM
F13142696: D18990.diff
Fri, May 3, 6:36 AM
F13135642: D18990.id.diff
Thu, May 2, 9:57 AM
Unknown Object (File)
Fri, Apr 26, 4:43 AM
Unknown Object (File)
Thu, Apr 25, 3:49 AM
Unknown Object (File)
Fri, Apr 19, 7:16 PM
Unknown Object (File)
Tue, Apr 16, 1:54 PM
Unknown Object (File)
Thu, Apr 4, 5:17 AM
Subscribers
None

Details

Summary

Ref T13060. Ref T7339. Ref T5554. Although I don't plan to pursue resolving the latter two issues for now, I think we do have enough information to be confident that setlocale() is the ultimate pathway forward.

Add some wrappers with error checks and unit tests for the day that we eventually tackle T7339/T5554, and so we're on better footing if the setlocale() change in T13060 has unintended effects.

Test Plan

Ran unit tests, got a pass.

Diff Detail

Repository
rPHU libphutil
Branch
utf83
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19338
Build 26141: Run Core Tests
Build 26140: arc lint + arc unit

Event Timeline

  • Add a test that phutil_set_system_locale('duck.quack') raises an exception.
This revision is now accepted and ready to land.Feb 5 2018, 8:27 PM
This revision was automatically updated to reflect the committed changes.