Page MenuHomePhabricator

Add some sytem locale utilities to libphutil
ClosedPublic

Authored by epriestley on Feb 4 2018, 3:52 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 23, 3:09 AM
Unknown Object (File)
Tue, Nov 19, 5:59 AM
Unknown Object (File)
Sat, Nov 16, 6:54 AM
Unknown Object (File)
Thu, Nov 14, 5:34 AM
Unknown Object (File)
Tue, Nov 12, 10:23 AM
Unknown Object (File)
Mon, Nov 11, 11:31 PM
Unknown Object (File)
Oct 21 2024, 5:58 AM
Unknown Object (File)
Oct 17 2024, 12:56 PM
Subscribers
None

Details

Summary

Ref T13060. Ref T7339. Ref T5554. Although I don't plan to pursue resolving the latter two issues for now, I think we do have enough information to be confident that setlocale() is the ultimate pathway forward.

Add some wrappers with error checks and unit tests for the day that we eventually tackle T7339/T5554, and so we're on better footing if the setlocale() change in T13060 has unintended effects.

Test Plan

Ran unit tests, got a pass.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

  • Add a test that phutil_set_system_locale('duck.quack') raises an exception.
This revision is now accepted and ready to land.Feb 5 2018, 8:27 PM
This revision was automatically updated to reflect the committed changes.