Page MenuHomePhabricator

Make minor correctness and display improvements to pull logs
ClosedPublic

Authored by epriestley on Jan 23 2018, 4:28 PM.
Tags
None
Referenced Files
F13268204: D18917.diff
Wed, May 29, 4:46 AM
F13256467: D18917.id.diff
Sat, May 25, 12:36 PM
F13253709: D18917.diff
Sat, May 25, 2:52 AM
F13231899: D18917.diff
Tue, May 21, 12:51 AM
F13193892: D18917.id45348.diff
Sun, May 12, 6:56 PM
F13186525: D18917.diff
Sat, May 11, 3:41 AM
F13181641: D18917.diff
Thu, May 9, 2:04 PM
F13175142: D18917.diff
Wed, May 8, 3:37 AM
Subscribers
None

Details

Summary

Depends on D18915. Ref T13046.

  • Distinguish between HTTP and HTTPS.
  • Use more constants and fewer magical strings.
  • For HTTP responses, give them better type information and more helpful UI behaviors.
Test Plan

Pulled over SSH and HTTP. Reviewed resulting logs from the web UI. Hit errors like missing/invalid credentials.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable