Page MenuHomePhabricator

Make minor correctness and display improvements to pull logs
ClosedPublic

Authored by epriestley on Jan 23 2018, 4:28 PM.
Tags
None
Referenced Files
F15393880: D18917.diff
Sat, Mar 15, 11:11 PM
F15390692: D18917.diff
Sat, Mar 15, 6:27 AM
F15335590: D18917.diff
Sat, Mar 8, 4:37 PM
Unknown Object (File)
Wed, Feb 26, 11:25 PM
Unknown Object (File)
Feb 9 2025, 5:01 AM
Unknown Object (File)
Feb 9 2025, 5:01 AM
Unknown Object (File)
Feb 9 2025, 5:01 AM
Unknown Object (File)
Feb 9 2025, 5:01 AM
Subscribers
None

Details

Summary

Depends on D18915. Ref T13046.

  • Distinguish between HTTP and HTTPS.
  • Use more constants and fewer magical strings.
  • For HTTP responses, give them better type information and more helpful UI behaviors.
Test Plan

Pulled over SSH and HTTP. Reviewed resulting logs from the web UI. Hit errors like missing/invalid credentials.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable