Page MenuHomePhabricator
Differential D18917

Make minor correctness and display improvements to pull logs
ClosedPublic
Actions

Authored by epriestley on Jan 23 2018, 4:28 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Feb 9, 5:01 AM
Unknown Object (File)
Sun, Feb 9, 5:01 AM
Unknown Object (File)
Sun, Feb 9, 5:01 AM
Unknown Object (File)
Sun, Feb 9, 5:01 AM
Unknown Object (File)
Fri, Jan 31, 11:33 PM
Unknown Object (File)
Tue, Jan 28, 5:50 PM
Unknown Object (File)
Tue, Jan 28, 3:04 AM
Unknown Object (File)
Fri, Jan 24, 11:13 PM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Maniphest Tasks
T13046: Surface repository pull logs in the web UI
Commits
rP778dfff277dc: Make minor correctness and display improvements to pull logs
Summary

Depends on D18915. Ref T13046.

  • Distinguish between HTTP and HTTPS.
  • Use more constants and fewer magical strings.
  • For HTTP responses, give them better type information and more helpful UI behaviors.
Test Plan

Pulled over SSH and HTTP. Reviewed resulting logs from the web UI. Hit errors like missing/invalid credentials.

Diff Detail

Repository
rP Phabricator
Branch
pull4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19135
Build 25839: Run Core Tests
Build 25838: arc lint + arc unit

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
controller/
24 lines
ssh/
4 lines
2 lines
view/
2 lines
repository/
storage/
51 lines

Diff 45348

View Options

src/applications/diffusion/controller/DiffusionServeController.php

Loading...
View Options

src/applications/diffusion/ssh/DiffusionGitUploadPackSSHWorkflow.php

Loading...
View Options

src/applications/diffusion/ssh/DiffusionSSHWorkflow.php

Loading...
View Options

src/applications/diffusion/view/DiffusionPullLogListView.php

Loading...
View Options

src/applications/repository/storage/PhabricatorRepositoryPullEvent.php

Loading...
Phabricator · Built by Phacility