Page MenuHomePhabricator

Add test coverage to the PasswordEngine upgrade workflow and fix a few bugs
ClosedPublic

Authored by epriestley on Jan 21 2018, 3:44 PM.
Tags
None
Referenced Files
F14080473: D18897.diff
Fri, Nov 22, 2:01 PM
Unknown Object (File)
Mon, Nov 18, 6:56 PM
Unknown Object (File)
Sun, Nov 17, 6:33 AM
Unknown Object (File)
Thu, Oct 24, 5:54 AM
Unknown Object (File)
Oct 23 2024, 6:30 AM
Unknown Object (File)
Oct 2 2024, 2:19 PM
Unknown Object (File)
Sep 27 2024, 9:23 PM
Unknown Object (File)
Sep 27 2024, 9:23 PM
Subscribers
None

Details

Summary

Ref T13043. When we verify a password and a better hasher is available, we automatically upgrade the stored hash to the stronger hasher.

Add test coverage for this workflow and fix a few bugs and issues, mostly related to shuffling the old hasher name into the transaction.

This doesn't touch anything user-visible yet.

Test Plan

Ran unit tests.

Diff Detail

Repository
rP Phabricator
Branch
revoke7
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19100
Build 25781: Run Core Tests
Build 25780: arc lint + arc unit