Page MenuHomePhabricator

Add test coverage to the PasswordEngine upgrade workflow and fix a few bugs
ClosedPublic

Authored by epriestley on Jan 21 2018, 3:44 PM.
Tags
None
Referenced Files
F18566460: D18897.id.diff
Tue, Sep 9, 2:39 PM
F18501974: D18897.diff
Thu, Sep 4, 10:05 PM
F18334233: D18897.diff
Mon, Aug 25, 4:44 AM
F18196476: D18897.id45313.diff
Sun, Aug 17, 6:15 PM
F18090687: D18897.id45312.diff
Aug 6 2025, 5:02 PM
F18081086: D18897.id45353.diff
Aug 4 2025, 10:36 PM
F18071824: D18897.id45353.diff
Aug 4 2025, 4:41 PM
F17853922: D18897.id.diff
Jul 27 2025, 2:30 PM
Subscribers
None

Details

Summary

Ref T13043. When we verify a password and a better hasher is available, we automatically upgrade the stored hash to the stronger hasher.

Add test coverage for this workflow and fix a few bugs and issues, mostly related to shuffling the old hasher name into the transaction.

This doesn't touch anything user-visible yet.

Test Plan

Ran unit tests.

Diff Detail

Repository
rP Phabricator
Branch
revoke7
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19100
Build 25781: Run Core Tests
Build 25780: arc lint + arc unit