Page MenuHomePhabricator

Add test coverage to the PasswordEngine upgrade workflow and fix a few bugs
ClosedPublic

Authored by epriestley on Jan 21 2018, 3:44 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 25, 1:49 AM
Unknown Object (File)
Fri, Apr 19, 7:06 PM
Unknown Object (File)
Sat, Apr 6, 5:00 PM
Unknown Object (File)
Tue, Apr 2, 4:46 PM
Unknown Object (File)
Tue, Apr 2, 4:46 PM
Unknown Object (File)
Tue, Apr 2, 4:46 PM
Unknown Object (File)
Tue, Apr 2, 4:46 PM
Unknown Object (File)
Tue, Apr 2, 4:46 PM
Subscribers
None

Details

Summary

Ref T13043. When we verify a password and a better hasher is available, we automatically upgrade the stored hash to the stronger hasher.

Add test coverage for this workflow and fix a few bugs and issues, mostly related to shuffling the old hasher name into the transaction.

This doesn't touch anything user-visible yet.

Test Plan

Ran unit tests.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable