Page MenuHomePhabricator

Add test coverage to the PasswordEngine upgrade workflow and fix a few bugs
ClosedPublic

Authored by epriestley on Jan 21 2018, 3:44 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Feb 9, 4:59 AM
Unknown Object (File)
Sun, Feb 9, 4:59 AM
Unknown Object (File)
Sun, Feb 9, 4:59 AM
Unknown Object (File)
Sun, Feb 9, 4:59 AM
Unknown Object (File)
Sun, Feb 9, 4:58 AM
Unknown Object (File)
Fri, Jan 31, 5:28 PM
Unknown Object (File)
Fri, Jan 31, 12:59 AM
Unknown Object (File)
Wed, Jan 29, 3:52 PM
Subscribers
None

Details

Summary

Ref T13043. When we verify a password and a better hasher is available, we automatically upgrade the stored hash to the stronger hasher.

Add test coverage for this workflow and fix a few bugs and issues, mostly related to shuffling the old hasher name into the transaction.

This doesn't touch anything user-visible yet.

Test Plan

Ran unit tests.

Diff Detail

Repository
rP Phabricator
Branch
revoke7
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19099
Build 25779: Run Core Tests
Build 25778: arc lint + arc unit