Page MenuHomePhabricator

Restore bulk edit support for remarkup fields (description, add comment)
ClosedPublic

Authored by epriestley on Jan 11 2018, 6:17 PM.
Tags
None
Referenced Files
F13987096: D18867.id.diff
Mon, Oct 21, 7:27 AM
F13973880: D18867.diff
Fri, Oct 18, 3:06 AM
Unknown Object (File)
Wed, Oct 9, 8:26 AM
Unknown Object (File)
Sep 6 2024, 1:43 AM
Unknown Object (File)
Sep 6 2024, 1:43 AM
Unknown Object (File)
Sep 6 2024, 1:43 AM
Unknown Object (File)
Sep 2 2024, 6:14 AM
Unknown Object (File)
Aug 25 2024, 10:37 PM
Subscribers
None

Details

Summary

Depends on D18866. Ref T13025. Fixes T12415. This makes the old "Add Comment" action work, and adds support for a new "Set description to" action (possibly, I could imagine "append description" being useful some day, maybe).

The implementation is just a <textarea />, not a whole fancy remarkup box with [Bold] [Italic] ... buttons, preview, typeaheads, etc. It would be nice to enrich this eventually but doing the rendering in pure JS is currently very involved.

This requires a little bit of gymnastics to get the transaction populated properly, and adds some extra validation since we need some code there anyway.

Test Plan
  • Changed the description of a task via bulk editor.
  • Added a comment to a task via bulk editor.

Diff Detail

Repository
rP Phabricator
Branch
bulk7
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 19037
Build 25685: Run Core Tests
Build 25684: arc lint + arc unit