Page MenuHomePhabricator

Always show "X requested review" in mail to stop some undraft mail from being dropped
ClosedPublic

Authored by epriestley on Jan 3 2018, 9:43 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Feb 9, 4:55 AM
Unknown Object (File)
Sun, Feb 9, 4:55 AM
Unknown Object (File)
Sun, Feb 9, 4:55 AM
Unknown Object (File)
Jan 28 2025, 2:56 AM
Unknown Object (File)
Jan 27 2025, 9:48 AM
Unknown Object (File)
Jan 24 2025, 10:58 PM
Unknown Object (File)
Jan 24 2025, 10:58 PM
Unknown Object (File)
Jan 24 2025, 10:58 PM
Subscribers
None

Details

Summary

Ref T13035. See that task for a description of the issue.

Test Plan
  • Enabled prototypes.
  • Disabled all Herald rules that trigger Harbormaster builds.
  • Created a new revision.
  • Before patch: initial review request email was dropped.
  • After patch: initial review request email is sent.

Diff Detail

Repository
rP Phabricator
Branch
draft1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18999
Build 25628: Run Core Tests
Build 25627: arc lint + arc unit