Page MenuHomePhabricator

Always show "X requested review" in mail to stop some undraft mail from being dropped
ClosedPublic

Authored by epriestley on Jan 3 2018, 9:43 PM.
Tags
None
Referenced Files
F15411082: D18851.diff
Wed, Mar 19, 8:49 AM
F15399820: D18851.diff
Mon, Mar 17, 7:54 AM
F15369572: D18851.id45221.diff
Wed, Mar 12, 7:15 AM
F15341532: D18851.diff
Sun, Mar 9, 8:44 PM
F15334902: D18851.diff
Sat, Mar 8, 1:12 PM
Unknown Object (File)
Feb 9 2025, 4:55 AM
Unknown Object (File)
Feb 9 2025, 4:55 AM
Unknown Object (File)
Feb 9 2025, 4:55 AM
Subscribers
None

Details

Summary

Ref T13035. See that task for a description of the issue.

Test Plan
  • Enabled prototypes.
  • Disabled all Herald rules that trigger Harbormaster builds.
  • Created a new revision.
  • Before patch: initial review request email was dropped.
  • After patch: initial review request email is sent.

Diff Detail

Repository
rP Phabricator
Branch
draft1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18999
Build 25628: Run Core Tests
Build 25627: arc lint + arc unit