Always show "X requested review" in mail to stop some undraft mail from being dropped
ClosedPublic
Actions

Authored by epriestley on Jan 3 2018, 9:43 PM.

Details

Reviewers

Maniphest Tasks

T13035: Differential drops draft mail when prototypes are enabled but no build plans are configured

Commits

rP33f7f65e81d4: (stable) Always show "X requested review" in mail to stop some undraft mail…
rPde6c68b91e57: Always show "X requested review" in mail to stop some undraft mail from being…

Summary

Ref T13035. See that task for a description of the issue.

Test Plan

Enabled prototypes.
Disabled all Herald rules that trigger Harbormaster builds.
Created a new revision.
Before patch: initial review request email was dropped.
After patch: initial review request email is sent.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Jan 3 2018, 9:43 PM

Harbormaster completed remote builds in B18999: Diff 45219.Jan 3 2018, 9:44 PM

epriestley requested review of this revision.Jan 3 2018, 9:44 PM

epriestley added a child revision: D18852: Fix a minor/harmless race with feed publishers in certain draft states.Jan 3 2018, 9:58 PM

amckinley accepted this revision.Jan 4 2018, 2:00 AM

This revision is now accepted and ready to land.Jan 4 2018, 2:00 AM

Closed by commit rPde6c68b91e57: Always show "X requested review" in mail to stop some undraft mail from being… (authored by epriestley). · Explain WhyJan 4 2018, 4:14 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in D18886: Fix an issue where certain configurations could fail to publish revision feed stories.Jan 19 2018, 10:27 PM

epriestley mentioned this in rP3b7547e726ed: Fix an issue where certain configurations could fail to publish revision feed….Jan 19 2018, 11:39 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

storage/

DifferentialTransaction.php

6 lines

Diff 45221

View Options

src/applications/differential/storage/DifferentialTransaction.php

Always show "X requested review" in mail to stop some undraft mail from being droppedClosedPublicActions