Page MenuHomePhabricator
Differential D18886

Fix an issue where certain configurations could fail to publish revision feed stories
ClosedPublic
Actions

Authored by epriestley on Jan 19 2018, 10:27 PM.
Tags
None
Referenced Files
F18672397: D18886.diff
Sep 25 2025, 7:27 AM
F18566452: D18886.id.diff
Sep 9 2025, 2:39 PM
F18501959: D18886.diff
Sep 4 2025, 10:05 PM
F18109713: D18886.id45298.diff
Aug 11 2025, 3:10 PM
F18103096: D18886.id.diff
Aug 10 2025, 1:41 AM
F18102958: D18886.diff
Aug 10 2025, 12:32 AM
F18102745: D18886.id45302.diff
Aug 9 2025, 11:05 PM
Unknown Object (File)
Jun 20 2025, 3:37 AM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Commits
rP3b7547e726ed: Fix an issue where certain configurations could fail to publish revision feed…
Summary

See PHI292. This is just a generalization of D18851: feed stories have the same issue as mail. Don't hide "requested a review" in either mail or feed.

Test Plan
  • Enable prototypes.
  • No harbormaster builds.
  • Create a revision.
    • Pre-patch: no feed story.
    • Post-patch: feed story.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
applications/
differential/
storage/
13 lines

Diff 45302

View Options

src/applications/differential/storage/DifferentialTransaction.php

Loading...
Phabricator · Built by Phacility