Page MenuHomePhabricator

When users browse to a submodule path in Diffusion explicitly, don't fatal
ClosedPublic

Authored by epriestley on Dec 13 2017, 3:08 PM.
Tags
None
Referenced Files
F13236513: D18831.id.diff
Tue, May 21, 9:57 AM
F13236404: D18831.id45175.diff
Tue, May 21, 9:36 AM
F13235971: D18831.diff
Tue, May 21, 7:22 AM
F13224168: D18831.id45175.diff
Sun, May 19, 6:51 AM
F13215134: D18831.diff
Fri, May 17, 3:14 PM
F13209497: D18831.id.diff
Fri, May 17, 12:34 AM
F13198824: D18831.diff
Mon, May 13, 10:08 AM
F13181257: D18831.diff
Thu, May 9, 10:31 AM
Subscribers
None

Details

Summary

Ref T13030. See PHI254. This behavior could be cleaner than I've made it, but it fixes the "this is totally broken" issue, replacing a fatal/exception with an informative (just not terribly useful) page.

Test Plan
  • Added a submodule to a repository.
  • In Diffusion, clicked some other file next to the submodule, then edited the URI to the submodule path instead.
    • Before patch: fatal.
    • After patch: relatively useful message about this being a submodule.

Note that it's normally hard to hit this URI directly. In the browse view, submodules are marked up as directories and linked to a separate submodule resolution flow.

Screen Shot 2017-12-13 at 7.04.45 AM.png (780×1 px, 117 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable