Page MenuHomePhabricator

When users browse to a submodule path in Diffusion explicitly, don't fatal
ClosedPublic

Authored by epriestley on Dec 13 2017, 3:08 PM.
Tags
None
Referenced Files
F13129153: D18831.diff
Wed, May 1, 12:40 AM
Unknown Object (File)
Sat, Apr 27, 11:47 AM
Unknown Object (File)
Wed, Apr 24, 9:22 AM
Unknown Object (File)
Mon, Apr 22, 6:15 PM
Unknown Object (File)
Fri, Apr 19, 7:02 PM
Unknown Object (File)
Tue, Apr 16, 11:14 PM
Unknown Object (File)
Sun, Apr 14, 12:54 AM
Unknown Object (File)
Sat, Apr 13, 8:23 AM
Subscribers
None

Details

Summary

Ref T13030. See PHI254. This behavior could be cleaner than I've made it, but it fixes the "this is totally broken" issue, replacing a fatal/exception with an informative (just not terribly useful) page.

Test Plan
  • Added a submodule to a repository.
  • In Diffusion, clicked some other file next to the submodule, then edited the URI to the submodule path instead.
    • Before patch: fatal.
    • After patch: relatively useful message about this being a submodule.

Note that it's normally hard to hit this URI directly. In the browse view, submodules are marked up as directories and linked to a separate submodule resolution flow.

Screen Shot 2017-12-13 at 7.04.45 AM.png (780×1 px, 117 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable