Page MenuHomePhabricator

When users browse to a submodule path in Diffusion explicitly, don't fatal
ClosedPublic

Authored by epriestley on Dec 13 2017, 3:08 PM.
Tags
None
Referenced Files
F18936488: D18831.diff
Nov 10 2025, 8:17 PM
F18768112: D18831.diff
Oct 8 2025, 1:49 AM
F18761527: D18831.id45186.diff
Oct 6 2025, 2:58 PM
F18725870: D18831.id.diff
Sep 30 2025, 5:58 AM
F18721007: D18831.diff
Sep 29 2025, 8:02 PM
F18626325: D18831.diff
Sep 16 2025, 1:01 AM
F18625465: D18831.id45175.diff
Sep 15 2025, 10:52 PM
F18566444: D18831.id.diff
Sep 9 2025, 2:38 PM
Subscribers
None

Details

Summary

Ref T13030. See PHI254. This behavior could be cleaner than I've made it, but it fixes the "this is totally broken" issue, replacing a fatal/exception with an informative (just not terribly useful) page.

Test Plan
  • Added a submodule to a repository.
  • In Diffusion, clicked some other file next to the submodule, then edited the URI to the submodule path instead.
    • Before patch: fatal.
    • After patch: relatively useful message about this being a submodule.

Note that it's normally hard to hit this URI directly. In the browse view, submodules are marked up as directories and linked to a separate submodule resolution flow.

Screen Shot 2017-12-13 at 7.04.45 AM.png (780×1 px, 117 KB)

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable