Page MenuHomePhabricator

When users browse to a submodule path in Diffusion explicitly, don't fatal
ClosedPublic

Authored by epriestley on Dec 13 2017, 3:08 PM.
Tags
None
Referenced Files
F15558557: D18831.id45175.diff
Tue, Apr 29, 3:45 AM
F15549515: D18831.id.diff
Sun, Apr 27, 6:13 AM
F15547520: D18831.diff
Sat, Apr 26, 7:34 PM
F15542235: D18831.diff
Fri, Apr 25, 4:20 PM
F15526494: D18831.diff
Mon, Apr 21, 9:08 PM
F15482354: D18831.id45186.diff
Wed, Apr 9, 4:50 AM
F15457788: D18831.diff
Mar 30 2025, 6:57 PM
F15448271: D18831.id45186.diff
Mar 28 2025, 3:49 AM
Subscribers
None

Details

Summary

Ref T13030. See PHI254. This behavior could be cleaner than I've made it, but it fixes the "this is totally broken" issue, replacing a fatal/exception with an informative (just not terribly useful) page.

Test Plan
  • Added a submodule to a repository.
  • In Diffusion, clicked some other file next to the submodule, then edited the URI to the submodule path instead.
    • Before patch: fatal.
    • After patch: relatively useful message about this being a submodule.

Note that it's normally hard to hit this URI directly. In the browse view, submodules are marked up as directories and linked to a separate submodule resolution flow.

Screen Shot 2017-12-13 at 7.04.45 AM.png (780×1 px, 117 KB)

Diff Detail

Repository
rP Phabricator
Branch
sub1
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/diffusion/view/DiffusionEmptyResultView.php:45XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 18948
Build 25556: Run Core Tests
Build 25555: arc lint + arc unit