Page MenuHomePhabricator

When users browse to a submodule path in Diffusion explicitly, don't fatal
ClosedPublic

Authored by epriestley on Dec 13 2017, 3:08 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jan 8, 2:08 PM
Unknown Object (File)
Sun, Dec 29, 7:54 AM
Unknown Object (File)
Dec 15 2024, 8:47 PM
Unknown Object (File)
Dec 13 2024, 6:25 PM
Unknown Object (File)
Dec 5 2024, 7:34 AM
Unknown Object (File)
Dec 3 2024, 12:18 PM
Unknown Object (File)
Nov 13 2024, 9:18 PM
Unknown Object (File)
Nov 4 2024, 10:35 AM
Subscribers
None

Details

Summary

Ref T13030. See PHI254. This behavior could be cleaner than I've made it, but it fixes the "this is totally broken" issue, replacing a fatal/exception with an informative (just not terribly useful) page.

Test Plan
  • Added a submodule to a repository.
  • In Diffusion, clicked some other file next to the submodule, then edited the URI to the submodule path instead.
    • Before patch: fatal.
    • After patch: relatively useful message about this being a submodule.

Note that it's normally hard to hit this URI directly. In the browse view, submodules are marked up as directories and linked to a separate submodule resolution flow.

Screen Shot 2017-12-13 at 7.04.45 AM.png (780×1 px, 117 KB)

Diff Detail

Repository
rP Phabricator
Branch
sub1
Lint
Lint Passed
SeverityLocationCodeMessage
Advicesrc/applications/diffusion/view/DiffusionEmptyResultView.php:45XHP16TODO Comment
Unit
Tests Passed
Build Status
Buildable 18948
Build 25556: Run Core Tests
Build 25555: arc lint + arc unit