Page MenuHomePhabricator

Fix an issue where Diffusion could fatal if the default branch was deleted
ClosedPublic

Authored by epriestley on Nov 30 2017, 8:35 PM.
Tags
None
Referenced Files
F15458758: D18811.id45138.diff
Mon, Mar 31, 6:43 AM
F15454735: D18811.diff
Sat, Mar 29, 8:02 PM
F15453091: D18811.id45132.diff
Sat, Mar 29, 9:19 AM
F15434627: D18811.id.diff
Tue, Mar 25, 4:42 AM
F15430348: D18811.diff
Mon, Mar 24, 7:13 AM
F15399222: D18811.diff
Mon, Mar 17, 3:25 AM
Unknown Object (File)
Feb 2 2025, 9:10 PM
Unknown Object (File)
Jan 27 2025, 1:48 PM
Subscribers
None

Details

Summary

See PHI234. In T12931 we improved the behavior of Diffusion when a repository's default branch is set to a branch that does not exist, but in T11823 the way refcursors work changed, and we can now get a cursor (just with no positions) back for a deleted branch. When we did, we didn't handle things gracefully.

Test Plan
  • Set default branch to a deleted branch, saw nice error instead of fatal.
  • Set default branch to a nonexistent branch which never existed, saw nice error.
  • Set default branch to existing "master", saw repository normally.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable