Page MenuHomePhabricator

Fix an issue where Diffusion could fatal if the default branch was deleted
ClosedPublic

Authored by epriestley on Nov 30 2017, 8:35 PM.
Tags
None
Referenced Files
F15668156: D18811.diff
Sun, May 25, 4:54 PM
Unknown Object (File)
Thu, May 8, 9:05 AM
Unknown Object (File)
Sun, May 4, 8:20 PM
Unknown Object (File)
Apr 25 2025, 3:52 AM
Unknown Object (File)
Apr 24 2025, 6:39 AM
Unknown Object (File)
Apr 16 2025, 12:10 PM
Unknown Object (File)
Apr 3 2025, 12:19 PM
Unknown Object (File)
Mar 31 2025, 6:43 AM
Subscribers
None

Details

Summary

See PHI234. In T12931 we improved the behavior of Diffusion when a repository's default branch is set to a branch that does not exist, but in T11823 the way refcursors work changed, and we can now get a cursor (just with no positions) back for a deleted branch. When we did, we didn't handle things gracefully.

Test Plan
  • Set default branch to a deleted branch, saw nice error instead of fatal.
  • Set default branch to a nonexistent branch which never existed, saw nice error.
  • Set default branch to existing "master", saw repository normally.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable