Page MenuHomePhabricator

Fix an issue where Diffusion could fatal if the default branch was deleted
ClosedPublic

Authored by epriestley on Nov 30 2017, 8:35 PM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 22 2024, 8:08 PM
Unknown Object (File)
Dec 7 2024, 12:26 AM
Unknown Object (File)
Dec 6 2024, 3:23 PM
Unknown Object (File)
Dec 6 2024, 2:47 PM
Unknown Object (File)
Nov 19 2024, 9:18 PM
Unknown Object (File)
Nov 16 2024, 11:31 AM
Unknown Object (File)
Nov 11 2024, 10:41 PM
Unknown Object (File)
Nov 5 2024, 10:20 AM
Subscribers
None

Details

Summary

See PHI234. In T12931 we improved the behavior of Diffusion when a repository's default branch is set to a branch that does not exist, but in T11823 the way refcursors work changed, and we can now get a cursor (just with no positions) back for a deleted branch. When we did, we didn't handle things gracefully.

Test Plan
  • Set default branch to a deleted branch, saw nice error instead of fatal.
  • Set default branch to a nonexistent branch which never existed, saw nice error.
  • Set default branch to existing "master", saw repository normally.

Diff Detail

Repository
rP Phabricator
Branch
overwrite2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18905
Build 25493: Run Core Tests
Build 25492: arc lint + arc unit