Page MenuHomePhabricator

Fix an issue where Diffusion could fatal if the default branch was deleted
ClosedPublic

Authored by epriestley on Nov 30 2017, 8:35 PM.
Tags
None
Referenced Files
F13375718: D18811.diff
Sat, Jun 29, 2:01 AM
F13331445: D18811.diff
Mon, Jun 17, 6:51 AM
F13303858: D18811.id45132.diff
Sat, Jun 8, 7:28 AM
F13298953: D18811.diff
Fri, Jun 7, 7:27 AM
F13281186: D18811.diff
Sun, Jun 2, 9:50 AM
F13273932: D18811.diff
Fri, May 31, 3:03 AM
F13268283: D18811.diff
May 29 2024, 4:52 AM
F13252041: D18811.diff
May 25 2024, 1:01 AM
Subscribers
None

Details

Summary

See PHI234. In T12931 we improved the behavior of Diffusion when a repository's default branch is set to a branch that does not exist, but in T11823 the way refcursors work changed, and we can now get a cursor (just with no positions) back for a deleted branch. When we did, we didn't handle things gracefully.

Test Plan
  • Set default branch to a deleted branch, saw nice error instead of fatal.
  • Set default branch to a nonexistent branch which never existed, saw nice error.
  • Set default branch to existing "master", saw repository normally.

Diff Detail

Repository
rP Phabricator
Branch
overwrite2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18905
Build 25493: Run Core Tests
Build 25492: arc lint + arc unit