Page MenuHomePhabricator

Specify a null behavior for the callsign sort column.
ClosedPublic

Authored by 20after4 on Nov 14 2017, 11:13 PM.
Tags
None
Referenced Files
F14970682: D18773.id45047.diff
Sun, Feb 16, 11:34 AM
Unknown Object (File)
Sun, Feb 9, 8:56 PM
Unknown Object (File)
Sun, Feb 9, 8:55 PM
Unknown Object (File)
Sun, Feb 9, 8:55 PM
Unknown Object (File)
Sun, Feb 9, 8:51 PM
Unknown Object (File)
Sat, Feb 8, 8:41 PM
Unknown Object (File)
Sun, Feb 2, 2:29 AM
Unknown Object (File)
Thu, Jan 30, 10:22 PM
Subscribers

Details

Summary

Fixes paging on the Diffusion Repository List.

PhabricatorRepositoryQuery needs to specify a behavior for null on the OderableColumns definition for the callsign column.

See https://phabricator.wikimedia.org/T180457

Test Plan
  1. On an instance with more than 100 repositories
    • some of which are missing a callsign
  2. Attempt to sort by callsign.
  3. See the sorted results

Previously:

  1. Exception: "Column "0" has null value, but does not specify a null behavior."

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable