Page MenuHomePhabricator

Specify a null behavior for the callsign sort column.
ClosedPublic

Authored by 20after4 on Nov 14 2017, 11:13 PM.
Tags
None
Referenced Files
F14076123: D18773.diff
Thu, Nov 21, 2:50 PM
Unknown Object (File)
Tue, Nov 12, 6:53 AM
Unknown Object (File)
Wed, Oct 23, 5:04 PM
Unknown Object (File)
Oct 20 2024, 11:42 AM
Unknown Object (File)
Oct 14 2024, 3:37 AM
Unknown Object (File)
Oct 1 2024, 11:09 PM
Unknown Object (File)
Aug 26 2024, 1:05 AM
Unknown Object (File)
Aug 25 2024, 7:01 PM
Subscribers

Details

Summary

Fixes paging on the Diffusion Repository List.

PhabricatorRepositoryQuery needs to specify a behavior for null on the OderableColumns definition for the callsign column.

See https://phabricator.wikimedia.org/T180457

Test Plan
  1. On an instance with more than 100 repositories
    • some of which are missing a callsign
  2. Attempt to sort by callsign.
  3. See the sorted results

Previously:

  1. Exception: "Column "0" has null value, but does not specify a null behavior."

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18830
Build 25381: Run Core Tests
Build 25380: arc lint + arc unit