Page MenuHomePhabricator

Specify a null behavior for the callsign sort column.
ClosedPublic

Authored by 20after4 on Nov 14 2017, 11:13 PM.
Tags
None
Referenced Files
F15456389: D18773.diff
Sun, Mar 30, 9:22 AM
F15446958: D18773.id.diff
Thu, Mar 27, 9:04 PM
F15444995: D18773.diff
Thu, Mar 27, 12:12 PM
F15428606: D18773.id45047.diff
Sun, Mar 23, 9:17 PM
F15382101: D18773.diff
Fri, Mar 14, 10:40 AM
Unknown Object (File)
Feb 16 2025, 11:34 AM
Unknown Object (File)
Feb 9 2025, 8:56 PM
Unknown Object (File)
Feb 9 2025, 8:55 PM
Subscribers

Details

Summary

Fixes paging on the Diffusion Repository List.

PhabricatorRepositoryQuery needs to specify a behavior for null on the OderableColumns definition for the callsign column.

See https://phabricator.wikimedia.org/T180457

Test Plan
  1. On an instance with more than 100 repositories
    • some of which are missing a callsign
  2. Attempt to sort by callsign.
  3. See the sorted results

Previously:

  1. Exception: "Column "0" has null value, but does not specify a null behavior."

Diff Detail

Repository
rP Phabricator
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18830
Build 25381: Run Core Tests
Build 25380: arc lint + arc unit