Page MenuHomePhabricator
Differential D18759

Fix some lint rendering issues when lines prior to other identical lines are removed
ClosedPublic
Actions

Authored by epriestley on Nov 1 2017, 7:35 PM.
Tags
None
Referenced Files
F15488673: D18759.id45020.diff
Fri, Apr 11, 1:15 AM
F15488179: D18759.id45021.diff
Thu, Apr 10, 8:12 PM
F15483072: D18759.id.diff
Wed, Apr 9, 9:43 AM
F15480582: D18759.diff
Tue, Apr 8, 3:01 PM
F15460991: D18759.id.diff
Tue, Apr 1, 4:09 AM
F15457663: D18759.diff
Sun, Mar 30, 5:38 PM
F15433026: D18759.id45021.diff
Mon, Mar 24, 8:57 PM
F15380955: D18759.id45021.diff
Fri, Mar 14, 5:08 AM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Commits
rARC622862e04799: (stable) Promote 2017 Week 14
rARC90546042144f: Fix some lint rendering issues when lines prior to other identical lines are…
Summary

See PHI191. This is a rehash of an earlier fix, but we didn't have a test case for this half yet.

Test Plan
  • Added a failing test, made it pass.
  • Added a linter like the one in PHI191, ran it, got a valid lint result instead of an exception.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
lint/
renderer/
47 lines
__tests__/
14 lines
data/
10 lines
4 lines
10 lines
4 lines

Diff 45021

View Options

src/lint/renderer/ArcanistConsoleLintRenderer.php

Loading...
View Options

src/lint/renderer/__tests__/ArcanistConsoleLintRendererTestCase.php

Loading...
View Options

src/lint/renderer/__tests__/data/rmmulti.expect

Loading...
View Options

src/lint/renderer/__tests__/data/rmmulti.txt

Loading...
View Options

src/lint/renderer/__tests__/data/rmmulti2.expect

Loading...
View Options

src/lint/renderer/__tests__/data/rmmulti2.txt

Loading...
Phabricator · Built by Phacility