Page MenuHomePhabricator
Differential D18759

Fix some lint rendering issues when lines prior to other identical lines are removed
ClosedPublic
Actions

Authored by epriestley on Nov 1 2017, 7:35 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 23, 9:14 AM
Unknown Object (File)
Tue, Nov 19, 10:39 AM
Unknown Object (File)
Fri, Nov 15, 5:51 AM
Unknown Object (File)
Sun, Nov 10, 8:19 PM
Unknown Object (File)
Wed, Nov 6, 7:47 PM
Unknown Object (File)
Mon, Oct 28, 2:59 AM
Unknown Object (File)
Oct 18 2024, 4:51 PM
Unknown Object (File)
Oct 15 2024, 3:38 AM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Commits
rARC622862e04799: (stable) Promote 2017 Week 14
rARC90546042144f: Fix some lint rendering issues when lines prior to other identical lines are…
Summary

See PHI191. This is a rehash of an earlier fix, but we didn't have a test case for this half yet.

Test Plan
  • Added a failing test, made it pass.
  • Added a linter like the one in PHI191, ran it, got a valid lint result instead of an exception.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
src/
lint/
renderer/
47 lines
__tests__/
14 lines
data/
10 lines
4 lines
10 lines
4 lines

Diff 45021

View Options

src/lint/renderer/ArcanistConsoleLintRenderer.php

Loading...
View Options

src/lint/renderer/__tests__/ArcanistConsoleLintRendererTestCase.php

Loading...
View Options

src/lint/renderer/__tests__/data/rmmulti.expect

Loading...
View Options

src/lint/renderer/__tests__/data/rmmulti.txt

Loading...
View Options

src/lint/renderer/__tests__/data/rmmulti2.expect

Loading...
View Options

src/lint/renderer/__tests__/data/rmmulti2.txt

Loading...
Phabricator · Built by Phacility