Fix some lint rendering issues when lines prior to other identical lines are removed
ClosedPublic
Actions

Authored by epriestley on Nov 1 2017, 7:35 PM.

Details

Reviewers

Commits

rARC622862e04799: (stable) Promote 2017 Week 14
rARC90546042144f: Fix some lint rendering issues when lines prior to other identical lines are…

Summary

See PHI191. This is a rehash of an earlier fix, but we didn't have a test case for this half yet.

Test Plan

Added a failing test, made it pass.
Added a linter like the one in PHI191, ran it, got a valid lint result instead of an exception.

Diff Detail

Repository

rARC Arcanist

Branch

lintnl1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 18798
Build 25337: Run Core Tests
Build 25336: arc lint + arc unit

Event Timeline

epriestley created this revision.Nov 1 2017, 7:35 PM

Harbormaster completed remote builds in B18798: Diff 45020.Nov 1 2017, 7:35 PM

epriestley requested review of this revision.Nov 1 2017, 7:35 PM

amckinley accepted this revision.Nov 1 2017, 8:49 PM

This revision is now accepted and ready to land.Nov 1 2017, 8:49 PM

Closed by commit rARC90546042144f: Fix some lint rendering issues when lines prior to other identical lines are… (authored by epriestley). · Explain WhyNov 2 2017, 12:19 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

lint/

renderer/

ArcanistConsoleLintRenderer.php

47 lines

__tests__/

ArcanistConsoleLintRendererTestCase.php

14 lines

data/

10 lines

4 lines

10 lines

4 lines

Diff 45020

View Options

src/lint/renderer/ArcanistConsoleLintRenderer.php

View Options

src/lint/renderer/tests/ArcanistConsoleLintRendererTestCase.php

View Options

src/lint/renderer/tests/data/rmmulti.expect

View Options

src/lint/renderer/tests/data/rmmulti.txt

View Options

src/lint/renderer/tests/data/rmmulti2.expect

View Options

src/lint/renderer/tests/data/rmmulti2.txt

Fix some lint rendering issues when lines prior to other identical lines are removedClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 45020

src/lint/renderer/ArcanistConsoleLintRenderer.php

src/lint/renderer/__tests__/ArcanistConsoleLintRendererTestCase.php

src/lint/renderer/__tests__/data/rmmulti.expect

src/lint/renderer/__tests__/data/rmmulti.txt

src/lint/renderer/__tests__/data/rmmulti2.expect

src/lint/renderer/__tests__/data/rmmulti2.txt

Fix some lint rendering issues when lines prior to other identical lines are removed
ClosedPublic
Actions

Revision Contents
Changeset List

src/lint/renderer/tests/ArcanistConsoleLintRendererTestCase.php

src/lint/renderer/tests/data/rmmulti.expect

src/lint/renderer/tests/data/rmmulti.txt

src/lint/renderer/tests/data/rmmulti2.expect

src/lint/renderer/tests/data/rmmulti2.txt