Page MenuHomePhabricator
Differential D18759

Fix some lint rendering issues when lines prior to other identical lines are removed
ClosedPublic
Actions

Authored by epriestley on Nov 1 2017, 7:35 PM.
Tags
None
Referenced Files
F15380955: D18759.id45021.diff
Fri, Mar 14, 5:08 AM
F15332040: D18759.diff
Fri, Mar 7, 4:17 PM
F15294490: D18759.id45020.diff
Wed, Mar 5, 8:19 AM
Unknown Object (File)
Feb 9 2025, 4:50 AM
Unknown Object (File)
Feb 9 2025, 4:50 AM
Unknown Object (File)
Feb 9 2025, 4:50 AM
Unknown Object (File)
Jan 27 2025, 8:34 AM
Unknown Object (File)
Jan 24 2025, 10:48 PM
View All Files
Subscribers
None

Details

Reviewers
amckinley
Commits
rARC622862e04799: (stable) Promote 2017 Week 14
rARC90546042144f: Fix some lint rendering issues when lines prior to other identical lines are…
Summary

See PHI191. This is a rehash of an earlier fix, but we didn't have a test case for this half yet.

Test Plan
  • Added a failing test, made it pass.
  • Added a linter like the one in PHI191, ran it, got a valid lint result instead of an exception.

Diff Detail

Repository
rARC Arcanist
Branch
lintnl1
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18798
Build 25337: Run Core Tests
Build 25336: arc lint + arc unit

Revision Contents
Changeset List

PathSize
src/
lint/
renderer/
47 lines
__tests__/
14 lines
data/
10 lines
4 lines
10 lines
4 lines

Diff 45020

View Options

src/lint/renderer/ArcanistConsoleLintRenderer.php

Loading...
View Options

src/lint/renderer/__tests__/ArcanistConsoleLintRendererTestCase.php

Loading...
View Options

src/lint/renderer/__tests__/data/rmmulti.expect

Loading...
View Options

src/lint/renderer/__tests__/data/rmmulti.txt

Loading...
View Options

src/lint/renderer/__tests__/data/rmmulti2.expect

Loading...
View Options

src/lint/renderer/__tests__/data/rmmulti2.txt

Loading...
Phabricator · Built by Phacility