Page MenuHomePhabricator

Return transactions from "differential.parsecommitmessage"
ClosedPublic

Authored by epriestley on Oct 27 2017, 5:02 PM.
Tags
None
Referenced Files
F14406224: D18741.diff
Mon, Dec 23, 10:35 AM
Unknown Object (File)
Tue, Dec 10, 2:54 PM
Unknown Object (File)
Mon, Dec 9, 4:00 PM
Unknown Object (File)
Sat, Dec 7, 6:54 AM
Unknown Object (File)
Sat, Dec 7, 6:30 AM
Unknown Object (File)
Wed, Nov 27, 10:01 AM
Unknown Object (File)
Nov 23 2024, 1:31 PM
Unknown Object (File)
Nov 22 2024, 7:49 AM
Subscribers
None

Details

Summary

Depends on D18740. Prepares arc to receive a --draft flag by letting us switch to "differential.revision.edit" instead of "differential.createrevision".

To "differential.revision.edit", we need a transaction list, but we can't automatically construct this list from a field map. Return the transaction list alongside the field map.

The next change uses this list (if available) to switch us to the modern API method.

Test Plan

Ran arc diff on the experiemntal branch with followup changes, got a new revision.

Diff Detail

Repository
rP Phabricator
Branch
diff5
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18760
Build 25281: Run Core Tests
Build 25280: arc lint + arc unit