Page MenuHomePhabricator

Tweak rate limiting point counts for omnipotent users
ClosedPublic

Authored by epriestley on Oct 14 2017, 3:00 PM.
Tags
None
Referenced Files
F13275541: D18708.diff
Fri, May 31, 4:54 AM
F13262290: D18708.diff
Mon, May 27, 1:59 AM
F13250781: D18708.id44914.diff
Fri, May 24, 5:27 PM
F13227020: D18708.id44913.diff
Mon, May 20, 12:44 AM
F13209128: D18708.diff
Thu, May 16, 9:57 PM
F13192078: D18708.id.diff
Sun, May 12, 4:55 AM
F13188771: D18708.diff
Sat, May 11, 5:29 AM
F13175580: D18708.diff
Wed, May 8, 5:59 AM
Subscribers
None

Details

Summary

Ref T13008. We haven't hit any issues with this, but I can imagine we might in the future.

When one host makes an intracluster request to another host, the $viewer ends up as the omnipotent viewer. This viewer isn't logged in, so they'll currently accumulate rate limit points at a high rate.

Instead, don't give them any points. These requests are always legitimate, and if they originated from a user request, that request should be the one getting rate limited.

Test Plan

Browsed around.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable