Page MenuHomePhabricator

Tweak rate limiting point counts for omnipotent users
ClosedPublic

Authored by epriestley on Oct 14 2017, 3:00 PM.
Tags
None
Referenced Files
F13175580: D18708.diff
Wed, May 8, 5:59 AM
Unknown Object (File)
Tue, May 7, 9:11 AM
Unknown Object (File)
Fri, May 3, 8:52 AM
Unknown Object (File)
Thu, Apr 25, 2:39 AM
Unknown Object (File)
Thu, Apr 11, 9:56 AM
Unknown Object (File)
Mar 10 2024, 5:54 AM
Unknown Object (File)
Mar 10 2024, 3:59 AM
Unknown Object (File)
Jan 29 2024, 10:00 AM
Subscribers
None

Details

Summary

Ref T13008. We haven't hit any issues with this, but I can imagine we might in the future.

When one host makes an intracluster request to another host, the $viewer ends up as the omnipotent viewer. This viewer isn't logged in, so they'll currently accumulate rate limit points at a high rate.

Instead, don't give them any points. These requests are always legitimate, and if they originated from a user request, that request should be the one getting rate limited.

Test Plan

Browsed around.

Diff Detail

Repository
rP Phabricator
Branch
limit1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 18692
Build 25181: Run Core Tests
Build 25180: arc lint + arc unit