Page MenuHomePhabricator

Tweak rate limiting point counts for omnipotent users
ClosedPublic

Authored by epriestley on Oct 14 2017, 3:00 PM.
Tags
None
Referenced Files
F17827348: D18708.diff
Sat, Jul 26, 8:11 AM
F17754567: D18708.diff
Tue, Jul 22, 11:01 AM
Unknown Object (File)
Jul 5 2025, 8:19 PM
Unknown Object (File)
Jul 5 2025, 11:22 AM
Unknown Object (File)
May 2 2025, 7:18 PM
Unknown Object (File)
Apr 28 2025, 4:01 AM
Unknown Object (File)
Apr 28 2025, 2:06 AM
Unknown Object (File)
Apr 27 2025, 2:57 PM
Subscribers
None

Details

Summary

Ref T13008. We haven't hit any issues with this, but I can imagine we might in the future.

When one host makes an intracluster request to another host, the $viewer ends up as the omnipotent viewer. This viewer isn't logged in, so they'll currently accumulate rate limit points at a high rate.

Instead, don't give them any points. These requests are always legitimate, and if they originated from a user request, that request should be the one getting rate limited.

Test Plan

Browsed around.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable