Page MenuHomePhabricator
Differential D18678

Fix parsing of Git branches with common and useful name "0"
ClosedPublic
Actions

Authored by epriestley on Oct 4 2017, 3:23 PM.
Tags
None
Referenced Files
F15460900: D18678.id44845.diff
Tue, Apr 1, 3:15 AM
F15448129: D18678.diff
Fri, Mar 28, 3:17 AM
F15432788: D18678.id44846.diff
Mon, Mar 24, 7:38 PM
F15431090: D18678.diff
Mon, Mar 24, 10:26 AM
F15430303: D18678.id44845.diff
Mon, Mar 24, 6:59 AM
F15428966: D18678.id.diff
Sun, Mar 23, 11:46 PM
F15403294: D18678.diff
Tue, Mar 18, 2:39 AM
F15399124: D18678.id44846.diff
Mon, Mar 17, 3:00 AM
View All Files
Subscribers
suren.jack

Details

Reviewers
amckinley
Commits
rARC282b83bcbed4: (stable) Promote 2017 Week 40
rARC76b54ce0a9af: Fix parsing of Git branches with common and useful name "0"
Summary

See https://discourse.phabricator-community.org/t/arc-has-a-spurious-failure-on-arc-diff/521. Oh, PHP!

Test Plan

Created a branch named "0", ran arc diff. Before: fatal. After: this beautiful revision.

Diff Detail

Repository
rARC Arcanist
Branch
0
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 18627
Build 25094: Run Core Tests
Build 25093: arc lint + arc unit

Event Timeline

epriestley created this revision.Oct 4 2017, 3:23 PM
Harbormaster completed remote builds in B18624: Diff 44842.Oct 4 2017, 3:23 PM
Harbormaster completed remote builds in B18624: Diff 44842.
epriestley added inline comments.Oct 4 2017, 3:24 PM
src/repository/api/ArcanistGitAPI.php
500–502

This just improves behavior if we somehow happen to have a ref named refs/heads/ exactly, with no actual branch name. This "should" not be possible.

516

This is the actual bugfix, "0" is falsey.

amckinley accepted this revision.Oct 4 2017, 3:29 PM
This revision is now accepted and ready to land.Oct 4 2017, 3:29 PM
epriestley updated this revision to Diff 44844.Oct 4 2017, 5:18 PM
  • Also fix a nearly identical bug which prevented "0" from appearing in arc branch.
Harbormaster completed remote builds in B18626: Diff 44844.Oct 4 2017, 5:18 PM
epriestley updated this revision to Diff 44845.Oct 4 2017, 5:20 PM
  • Found one more in arc land.
Closed by commit rARC76b54ce0a9af: Fix parsing of Git branches with common and useful name "0" (authored by epriestley). · Explain WhyOct 4 2017, 5:20 PM
This revision was automatically updated to reflect the committed changes.
Harbormaster completed remote builds in B18627: Diff 44845.Oct 4 2017, 5:21 PM
suren.jack added a subscriber: suren.jack.Oct 4 2017, 8:08 PM

Revision Contents
Changeset List

PathSize
src/
repository/
api/
8 lines
workflow/
2 lines

Diff 44845

View Options

src/repository/api/ArcanistGitAPI.php

Loading...
View Options

src/workflow/ArcanistLandWorkflow.php

Loading...
Phabricator · Built by Phacility