Paths

Table of Contentst

Differential D18678

Fix parsing of Git branches with common and useful name "0"
ClosedPublic
Actions

Authored by epriestley on Oct 4 2017, 3:23 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Nov 21, 7:03 PM

	Unknown Object (File)
	Mon, Nov 18, 8:10 AM

	Unknown Object (File)
	Thu, Nov 14, 11:34 AM

	Unknown Object (File)
	Sun, Nov 10, 11:57 AM

	Unknown Object (File)
	Wed, Nov 6, 8:49 AM

	Unknown Object (File)
	Sat, Nov 2, 4:18 PM

	Unknown Object (File)
	Sat, Nov 2, 1:16 AM

	Unknown Object (File)
	Fri, Nov 1, 1:06 PM

Subscribers

Details

Reviewers

Commits

rARC282b83bcbed4: (stable) Promote 2017 Week 40
rARC76b54ce0a9af: Fix parsing of Git branches with common and useful name "0"

Summary

See https://discourse.phabricator-community.org/t/arc-has-a-spurious-failure-on-arc-diff/521. Oh, PHP!

Test Plan

Created a branch named "0", ran arc diff. Before: fatal. After: this beautiful revision.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.Oct 4 2017, 3:23 PM

Harbormaster completed remote builds in B18624: Diff 44842.Oct 4 2017, 3:23 PM

Harbormaster completed remote builds in B18624: Diff 44842.

epriestley added inline comments.Oct 4 2017, 3:24 PM

src/repository/api/ArcanistGitAPI.php
500–502	This just improves behavior if we somehow happen to have a ref named `refs/heads/` exactly, with no actual branch name. This "should" not be possible.
516	This is the actual bugfix, "0" is falsey.

amckinley accepted this revision.Oct 4 2017, 3:29 PM

This revision is now accepted and ready to land.Oct 4 2017, 3:29 PM

Also fix a nearly identical bug which prevented "0" from appearing in arc branch.

Harbormaster completed remote builds in B18626: Diff 44844.Oct 4 2017, 5:18 PM

Found one more in arc land.

Closed by commit rARC76b54ce0a9af: Fix parsing of Git branches with common and useful name "0" (authored by epriestley). · Explain WhyOct 4 2017, 5:20 PM

This revision was automatically updated to reflect the committed changes.

Harbormaster completed remote builds in B18627: Diff 44845.Oct 4 2017, 5:21 PM

suren.jack added a subscriber: suren.jack.Oct 4 2017, 8:08 PM

Revision Contents
Changeset List

Path

Size

src/

repository/

api/

ArcanistGitAPI.php

8 lines

workflow/

ArcanistLandWorkflow.php

2 lines

Diff 44846

src/repository/api/ArcanistGitAPI.php

Loading...

src/workflow/ArcanistLandWorkflow.php

Loading...