Paths

Table of Contentst

Fix fatal when searching for "r matey prepare to be boarded"
ClosedPublic
Actions

Authored by epriestley on Sep 29 2017, 4:02 PM.

Tags

None

Referenced Files

	F14082531: D18661.id44806.diff
	Sat, Nov 23, 12:15 AM

	F14081237: D18661.diff
	Fri, Nov 22, 6:53 PM

	Unknown Object (File)
	Tue, Nov 19, 9:15 PM

	Unknown Object (File)
	Mon, Nov 18, 2:07 AM

	Unknown Object (File)
	Sat, Nov 16, 2:08 PM

	Unknown Object (File)
	Tue, Nov 12, 3:39 AM

	Unknown Object (File)
	Fri, Nov 8, 5:45 AM

	Unknown Object (File)
	Sat, Oct 26, 6:52 PM

View All Files

Subscribers

None

Details

Reviewers

amckinley

Commits

rPa3a6c4ed2edf: Fix fatal when searching for "r matey prepare to be boarded"

Summary

See https://discourse.phabricator-community.org/t/unrecoverable-fatal-error-on-repository-search-in-top-search-bar/503/2.

The Ferret engine replaced withNameContains(), but I missed this obscure callsite.

Test Plan

Searched for r matey prepare to be boarded.
Before: fatal.
After: no fatal.
Also searched for r <actual repository name>, got repository.

Diff Detail

Repository

rP Phabricator

Branch

jump1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 18585
Build 25033: Run Core Tests
Build 25032: arc lint + arc unit

Event Timeline

epriestley created this revision.Sep 29 2017, 4:02 PM

Harbormaster completed remote builds in B18585: Diff 44805.Sep 29 2017, 4:03 PM

yarrrr

This revision is now accepted and ready to land.Sep 29 2017, 4:41 PM

Closed by commit rPa3a6c4ed2edf: Fix fatal when searching for "r matey prepare to be boarded" (authored by epriestley). · Explain WhySep 29 2017, 4:45 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

search/

engine/

PhabricatorJumpNavHandler.php

24 lines

Diff 44805

View Options

src/applications/search/engine/PhabricatorJumpNavHandler.php

Fix fatal when searching for "r matey prepare to be boarded"ClosedPublicActions